Skip to content

ecdsa: rename {Signer, Verifier} => {SigningKey, VerifyKey}#140

Merged
tarcieri merged 1 commit into
masterfrom
rename-signing-and-verify-key-types
Sep 2, 2020
Merged

ecdsa: rename {Signer, Verifier} => {SigningKey, VerifyKey}#140
tarcieri merged 1 commit into
masterfrom
rename-signing-and-verify-key-types

Conversation

@tarcieri

@tarcieri tarcieri commented Sep 2, 2020

Copy link
Copy Markdown
Member

Should help prevent confusion with signature::{Signer, Verifier}.

@codecov-commenter

codecov-commenter commented Sep 2, 2020

Copy link
Copy Markdown

Codecov Report

Merging #140 into master will decrease coverage by 0.72%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   62.24%   61.51%   -0.73%     
==========================================
  Files           8        8              
  Lines         339      343       +4     
==========================================
  Hits          211      211              
- Misses        128      132       +4     
Impacted Files Coverage Δ
ecdsa/src/lib.rs 47.61% <ø> (ø)
ecdsa/src/rfc6979.rs 94.87% <ø> (ø)
ecdsa/src/sign.rs 0.00% <0.00%> (ø)
ecdsa/src/verify.rs 0.00% <0.00%> (ø)
ed25519/src/lib.rs 65.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d9ca6f...8d3d768. Read the comment docs.

Should help prevent confusion with `signature::{Signer, Verifier}`.
@tarcieri tarcieri force-pushed the rename-signing-and-verify-key-types branch from 8b8b721 to 8d3d768 Compare September 2, 2020 17:42
@tarcieri tarcieri merged commit 6758538 into master Sep 2, 2020
@tarcieri tarcieri deleted the rename-signing-and-verify-key-types branch September 2, 2020 17:44
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Sep 2, 2020
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Sep 2, 2020
@tarcieri tarcieri mentioned this pull request Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants